Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Errors
18 450

Files

Files Errors
com/gotjava/model/calendar/CalendarEvent.java 64
com/gotjava/model/calendar/CalendarSpan.java 74
com/gotjava/model/calendar/EventComparator.java 10
com/gotjava/system/calendar/CalendarDAO.java 13
com/gotjava/system/calendar/CalendarManager.java 22
com/gotjava/system/calendar/CalendarTest.java 24
com/gotjava/system/calendar/exceptions/CalendarException.java 8
com/gotjava/system/calendar/factory/CalendarFactory.java 2
com/gotjava/system/calendar/hibernate/CalendarDAO_Impl.java 15
com/gotjava/web/struts/actions/AddEventAction.java 16
com/gotjava/web/taglibs/calendar/DateTag.java 21
com/gotjava/web/taglibs/calendar/CalendarTag.java 44
com/gotjava/web/taglibs/calendar/DaysOfWeekTag.java 25
com/gotjava/web/taglibs/calendar/EventsTag.java 31
com/gotjava/web/taglibs/calendar/SpanTag.java 32
com/gotjava/web/taglibs/calendar/HasEventTag.java 13
com/gotjava/web/taglibs/calendar/NoEventTag.java 15
com/gotjava/web/taglibs/calendar/EventTag.java 21

com/gotjava/model/calendar/CalendarEvent.java

Error Line
variable 'dtend' missing Javadoc. 50
variable 'creationDate' missing Javadoc. 51
variable 'modifiedDate' missing Javadoc. 52
variable 'user' missing Javadoc. 53
variable 'classification' missing Javadoc. 54
variable 'location' missing Javadoc. 55
line contains a tab character 56
variable 'uid' missing Javadoc. 56
variable 'status' missing Javadoc. 57
variable 'summary' missing Javadoc. 58
variable 'duration' missing Javadoc. 59
variable 'dtstart' missing Javadoc. 60
variable 'organizer' missing Javadoc. 61
variable 'priority' missing Javadoc. 62
variable 'transparent' missing Javadoc. 63
variable 'url' missing Javadoc. 64
variable 'lastModified' missing Javadoc. 65
variable 'seq' missing Javadoc. 66
variable 'category' missing Javadoc. 67
method is missing a Javadoc comment. 69
Expected an @return tag. 75
Expected @param tag for 'dtstart'. 82
Expected an @return tag. 89
Expected @param tag for 'dtend'. 100
line longer than 80 characters 106
Expected an @return tag. 109
line longer than 80 characters 114
Expected @param tag for 'classification'. 117
Expected an @return tag. 125
Expected @param tag for 'location'. 133
Expected an @return tag. 141
Expected @param tag for 'organizer'. 149
Expected an @return tag. 158
Expected @param tag for 'priority'. 167
Expected an @return tag. 175
Expected @param tag for 'transparent'. 183
Expected an @return tag. 191
Expected @param tag for 'url'. 199
Expected an @return tag. 211
line contains a tab character 211
line contains a tab character 212
line contains a tab character 213
line contains a tab character 226
Expected @param tag for 'uid'. 226
line contains a tab character 227
line contains a tab character 228
Expected an @return tag. 232
Expected @param tag for 'lastModified'. 239
Expected an @return tag. 247
Expected @param tag for 'seq'. 255
Expected an @return tag. 263
Expected @param tag for 'status'. 271
Expected an @return tag. 278
Expected @param tag for 'summary'. 285
Expected an @return tag. 292
Expected @param tag for 'duration'. 300
Expected an @return tag. 309
Expected @param tag for 'category'. 316
method is missing a Javadoc comment. 320
method is missing a Javadoc comment. 324
method is missing a Javadoc comment. 328
method is missing a Javadoc comment. 332
method is missing a Javadoc comment. 336
method is missing a Javadoc comment. 340

com/gotjava/model/calendar/CalendarSpan.java

Error Line
Redundant import from the same package. 30
Unused import - java.text.SimpleDateFormat 37
type Javadoc comment is missing an @author tag. 41
variable 'YEAR' missing Javadoc. 43
variable 'MONTH' missing Javadoc. 44
variable 'WEEK' missing Javadoc. 45
variable 'DAY' missing Javadoc. 46
variable 'm_startDate' missing Javadoc. 48
variable 'm_startDate' must be private and have accessor methods. 48
variable 'm_endDate' missing Javadoc. 49
variable 'm_endDate' must be private and have accessor methods. 49
variable 'm_span' missing Javadoc. 51
variable 'm_span' must be private and have accessor methods. 51
variable 'm_events' missing Javadoc. 53
variable 'm_events' must be private and have accessor methods. 53
Expected an @return tag. 72
Expected an @return tag. 79
Expected an @return tag. 86
Expected @param tag for 'event'. 97
Expected an @return tag. 106
Expected @param tag for 'date'. 106
method is missing a Javadoc comment. 110
'{' is not preceeded with whitespace. 110
method is missing a Javadoc comment. 114
'{' is not preceeded with whitespace. 114
'if' is not followed by whitespace. 116
'(' is followed by whitespace. 116
')' is preceeded by whitespace. 116
'{' is not preceeded with whitespace. 116
'{' is not preceeded with whitespace. 119
'if' construct must use '{}'s. 124
'if' is not followed by whitespace. 124
')' is preceeded by whitespace. 124
'else' construct must use '{}'s. 126
'if' construct must use '{}'s. 130
'if' is not followed by whitespace. 130
')' is preceeded by whitespace. 130
'if' construct must use '{}'s. 132
')' is preceeded by whitespace. 132
'else' construct must use '{}'s. 134
'if' construct must use '{}'s. 142
'if' is not followed by whitespace. 142
',' needs to be followed by whitespace. 145
',' needs to be followed by whitespace. 146
'for' is not followed by whitespace. 147
'=' is not preceeded with whitespace. 147
'=' is not followed by whitespace. 147
'{' is not preceeded with whitespace. 147
cast needs to be followed by whitespace. 148
'for' is not followed by whitespace. 153
'=' is not preceeded with whitespace. 153
'=' is not followed by whitespace. 153
'-' is not preceeded with whitespace. 153
'-' is not followed by whitespace. 153
'{' is not preceeded with whitespace. 153
',' needs to be followed by whitespace. 154
',' needs to be followed by whitespace. 157
'for' is not followed by whitespace. 159
'=' is not preceeded with whitespace. 159
'=' is not followed by whitespace. 159
'{' is not preceeded with whitespace. 159
cast needs to be followed by whitespace. 160
method is missing a Javadoc comment. 170
'+' is not preceeded with whitespace. 187
'+' is not followed by whitespace. 187
line longer than 80 characters 199
'+' is not preceeded with whitespace. 202
'+' is not followed by whitespace. 202
line longer than 80 characters 211
'+' is not preceeded with whitespace. 214
'+' is not followed by whitespace. 214
line longer than 80 characters 215
'+' is not preceeded with whitespace. 225
'+' is not followed by whitespace. 225

com/gotjava/model/calendar/EventComparator.java

Error Line
method is missing a Javadoc comment. 11
'{' is not preceeded with whitespace. 11
Expected an @return tag. 17
Expected @param tag for 'evt1'. 17
Expected @param tag for 'evt2'. 17
'{' is not preceeded with whitespace. 17
Expected an @return tag. 25
Expected @param tag for 'evt1'. 25
Expected @param tag for 'evt2'. 25
'{' is not preceeded with whitespace. 25

com/gotjava/system/calendar/CalendarDAO.java

Error Line
type Javadoc comment is missing an @author tag. 40
Expected an @return tag. 45
redundant 'public' modifier. 45
Expected @param tag for 'event'. 45
Expected @throws tag for 'CalendarException'. 45
redundant 'public' modifier. 47
method is missing a Javadoc comment. 47
redundant 'public' modifier. 49
method is missing a Javadoc comment. 49
redundant 'public' modifier. 51
method is missing a Javadoc comment. 51
line longer than 80 characters 57
redundant 'public' modifier. 57

com/gotjava/system/calendar/CalendarManager.java

Error Line
Redundant import from the same package. 33
type Javadoc comment is missing an @author tag. 42
variable 'm_instance' missing Javadoc. 44
variable 'm_instance' must match pattern '^[a-z][a-zA-Z0-9]*$'. 44
variable 'm_calendarDAO' missing Javadoc. 45
variable 'm_calendarDAO' must match pattern '^[a-z][a-zA-Z0-9]*$'. 45
method is missing a Javadoc comment. 47
method is missing a Javadoc comment. 52
'static' modifier out of order with the JLS suggestions. 52
'if' construct must use '{}'s. 53
line longer than 80 characters 61
Expected an @return tag. 61
Expected @param tag for 'user'. 61
Expected @param tag for 'span'. 61
Expected @param tag for 'date'. 61
Expected @throws tag for 'CalendarException'. 61
Expected an @return tag. 68
Expected @param tag for 'user'. 68
Expected @param tag for 'category'. 68
method is missing a Javadoc comment. 73
method is missing a Javadoc comment. 78
method is missing a Javadoc comment. 85

com/gotjava/system/calendar/CalendarTest.java

Error Line
Unused import - com.gotjava.system.signon.factory.UserDAOFactory 3
Unused import - com.gotjava.system.signon.UserDAO 4
Unused import - com.gotjava.model.signon.JLCPUser 5
type Javadoc comment is missing an @author tag. 18
method is missing a Javadoc comment. 21
'{' is not preceeded with whitespace. 21
'try' is not followed by whitespace. 22
'{' is not preceeded with whitespace. 22
line longer than 80 characters 24
',' needs to be followed by whitespace. 24
'+' is not preceeded with whitespace. 25
'+' is not followed by whitespace. 25
'+' is not preceeded with whitespace. 25
'+' should be on a new line. 25
'while' is not followed by whitespace. 29
'{' is not preceeded with whitespace. 29
'while' is not followed by whitespace. 32
'{' is not preceeded with whitespace. 32
'+' is not preceeded with whitespace. 34
'+' is not followed by whitespace. 34
'+' is not preceeded with whitespace. 34
'+' should be on a new line. 34
'catch' is not followed by whitespace. 38
'{' is not preceeded with whitespace. 38

com/gotjava/system/calendar/exceptions/CalendarException.java

Error Line
method is missing a Javadoc comment. 38
method is missing a Javadoc comment. 42
'{' is not preceeded with whitespace. 42
',' needs to be followed by whitespace. 43
method is missing a Javadoc comment. 46
'{' is not preceeded with whitespace. 46
method is missing a Javadoc comment. 50
'{' is not preceeded with whitespace. 50

com/gotjava/system/calendar/factory/CalendarFactory.java

Error Line
Expected an @return tag. 44
'{' is not preceeded with whitespace. 44

com/gotjava/system/calendar/hibernate/CalendarDAO_Impl.java

Error Line
line longer than 80 characters 24
type name 'CalendarDAO_Impl' must match pattern '^[A-Z][a-zA-Z0-9]*$'. 24
Expected an @return tag. 30
Expected @param tag for 'event'. 30
Expected @throws tag for 'CalendarException'. 30
method is missing a Javadoc comment. 47
method is missing a Javadoc comment. 65
method is missing a Javadoc comment. 85
line longer than 80 characters 94
',' needs to be followed by whitespace. 94
line longer than 80 characters 111
line longer than 80 characters 123
'+' should be on a new line. 123
line longer than 80 characters 124
line longer than 80 characters 132

com/gotjava/web/struts/actions/AddEventAction.java

Error Line
Avoid using the '.*' form of import. 3
Unused import - java.net.URL 18
type Javadoc comment is missing an @author tag. 27
line longer than 80 characters 30
method is missing a Javadoc comment. 30
line longer than 80 characters 40
line longer than 80 characters 42
'(' is followed by whitespace. 47
line longer than 80 characters 49
line longer than 80 characters 51
line longer than 80 characters 52
'+' is not preceeded with whitespace. 66
'+' is not followed by whitespace. 66
line longer than 80 characters 76
variable 'USER_KEY' missing Javadoc. 83
variable 'USER_KEY' must match pattern '^[a-z][a-zA-Z0-9]*$'. 83

com/gotjava/web/taglibs/calendar/DateTag.java

Error Line
type Javadoc comment is missing an @author tag. 17
'{' is not preceeded with whitespace. 17
variable 'm_format' missing Javadoc. 19
variable 'm_format' must match pattern '^[a-z][a-zA-Z0-9]*$'. 19
variable 'm_property' missing Javadoc. 20
variable 'm_property' must match pattern '^[a-z][a-zA-Z0-9]*$'. 20
variable 'm_dateFormat' missing Javadoc. 22
variable 'm_dateFormat' must match pattern '^[a-z][a-zA-Z0-9]*$'. 22
method is missing a Javadoc comment. 24
'{' should be on the previous line. 25
'{' should be on the previous line. 32
'}' should be on the same line. 35
'{' should be on the previous line. 37
method is missing a Javadoc comment. 44
'{' is not preceeded with whitespace. 44
method is missing a Javadoc comment. 48
'{' is not preceeded with whitespace. 48
method is missing a Javadoc comment. 52
'{' is not preceeded with whitespace. 52
method is missing a Javadoc comment. 56
'{' is not preceeded with whitespace. 56

com/gotjava/web/taglibs/calendar/CalendarTag.java

Error Line
Unused import - javax.servlet.jsp.tagext.TagSupport 33
Avoid using the '.*' form of import. 47
variable 'm_span' missing Javadoc. 58
variable 'm_span' must match pattern '^[a-z][a-zA-Z0-9]*$'. 58
variable 'm_spanString' missing Javadoc. 59
variable 'm_spanString' must match pattern '^[a-z][a-zA-Z0-9]*$'. 59
variable 'm_date' missing Javadoc. 60
variable 'm_date' must match pattern '^[a-z][a-zA-Z0-9]*$'. 60
method is missing a Javadoc comment. 62
'{' should be on the previous line. 64
'if' construct must use '{}'s. 67
'{' is not preceeded with whitespace. 73
'}' should be on the same line. 77
'else' is not followed by whitespace. 78
'{' is not preceeded with whitespace. 78
'if' is not followed by whitespace. 81
'{' is not preceeded with whitespace. 81
'}' should be on the same line. 85
',' needs to be followed by whitespace. 92
',' needs to be followed by whitespace. 93
method is missing a Javadoc comment. 99
'{' should be on the previous line. 100
'{' should be on the previous line. 102
'}' should be on the same line. 111
Empty catch block. 113
'{' should be on the previous line. 113
method is missing a Javadoc comment. 119
'{' is not preceeded with whitespace. 119
method is missing a Javadoc comment. 125
parameter 'm_date' must match pattern '^[a-z][a-zA-Z0-9]*$'. 125
method is missing a Javadoc comment. 128
'if' is not followed by whitespace. 130
'{' is not preceeded with whitespace. 130
'}' should be on the same line. 132
'if' is not followed by whitespace. 133
'{' is not preceeded with whitespace. 133
'}' should be on the same line. 135
'if' is not followed by whitespace. 136
'{' is not preceeded with whitespace. 136
'}' should be on the same line. 138
'if' is not followed by whitespace. 139
'{' is not preceeded with whitespace. 139
method is missing a Javadoc comment. 143
method is missing a Javadoc comment. 146

com/gotjava/web/taglibs/calendar/DaysOfWeekTag.java

Error Line
variable 'm_counter' missing Javadoc. 20
variable 'm_counter' must match pattern '^[a-z][a-zA-Z0-9]*$'. 20
variable 'm_cal' missing Javadoc. 21
variable 'm_cal' must match pattern '^[a-z][a-zA-Z0-9]*$'. 21
method is missing a Javadoc comment. 23
'if' is not followed by whitespace. 27
')' is preceeded by whitespace. 27
'{' is not preceeded with whitespace. 27
line longer than 80 characters 28
',' needs to be followed by whitespace. 37
',' needs to be followed by whitespace. 38
'}' should be on the same line. 43
'else' is not followed by whitespace. 44
'{' is not preceeded with whitespace. 44
method is missing a Javadoc comment. 51
'{' should be on the previous line. 52
'{' should be on the previous line. 54
'}' should be on the same line. 59
Empty catch block. 61
'{' should be on the previous line. 61
'{' should be on the previous line. 64
',' needs to be followed by whitespace. 65
',' needs to be followed by whitespace. 66
'}' should be on the same line. 69
'else' construct must use '{}'s. 70

com/gotjava/web/taglibs/calendar/EventsTag.java

Error Line
Unused import - java.util.Date 10
variable 'm_counter' missing Javadoc. 20
variable 'm_counter' must match pattern '^[a-z][a-zA-Z0-9]*$'. 20
variable 'm_id' missing Javadoc. 21
variable 'm_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. 21
variable 'm_events' missing Javadoc. 22
variable 'm_events' must match pattern '^[a-z][a-zA-Z0-9]*$'. 22
method is missing a Javadoc comment. 24
line longer than 80 characters 28
'if' is not followed by whitespace. 32
'{' is not preceeded with whitespace. 32
',' needs to be followed by whitespace. 33
'}' should be on the same line. 36
'else' construct must use '{}'s. 37
method is missing a Javadoc comment. 43
'{' should be on the previous line. 44
'{' should be on the previous line. 46
'}' should be on the same line. 51
Empty catch block. 53
'{' should be on the previous line. 53
'if' is not followed by whitespace. 55
'{' is not preceeded with whitespace. 55
',' needs to be followed by whitespace. 56
'}' should be on the same line. 59
'else' construct must use '{}'s. 60
method is missing a Javadoc comment. 64
'{' is not preceeded with whitespace. 64
method is missing a Javadoc comment. 69
'{' is not preceeded with whitespace. 69
method is missing a Javadoc comment. 73
'{' is not preceeded with whitespace. 73

com/gotjava/web/taglibs/calendar/SpanTag.java

Error Line
Unused import - javax.servlet.jsp.tagext.TagSupport 5
variable 'm_spans' missing Javadoc. 20
variable 'm_spans' must match pattern '^[a-z][a-zA-Z0-9]*$'. 20
variable 'm_span' missing Javadoc. 22
variable 'm_span' must match pattern '^[a-z][a-zA-Z0-9]*$'. 22
variable 'm_spanString' missing Javadoc. 23
variable 'm_spanString' must match pattern '^[a-z][a-zA-Z0-9]*$'. 23
method is missing a Javadoc comment. 25
line longer than 80 characters 28
'if' construct must use '{}'s. 32
method is missing a Javadoc comment. 44
'{' should be on the previous line. 45
'{' should be on the previous line. 47
'}' should be on the same line. 52
Empty catch block. 54
'{' should be on the previous line. 54
'{' should be on the previous line. 57
'}' should be on the same line. 62
'else' construct must use '{}'s. 63
method is missing a Javadoc comment. 67
'if' is not followed by whitespace. 69
'{' is not preceeded with whitespace. 69
'}' should be on the same line. 71
'if' is not followed by whitespace. 72
'{' is not preceeded with whitespace. 72
'}' should be on the same line. 74
'if' is not followed by whitespace. 75
'{' is not preceeded with whitespace. 75
'}' should be on the same line. 77
'if' is not followed by whitespace. 78
'{' is not preceeded with whitespace. 78
method is missing a Javadoc comment. 83

com/gotjava/web/taglibs/calendar/HasEventTag.java

Error Line
Unused import - java.util.Date 10
type Javadoc comment is missing an @author tag. 21
method is missing a Javadoc comment. 25
line longer than 80 characters 27
'if' construct must use '{}'s. 31
'if' is not followed by whitespace. 31
'else' construct must use '{}'s. 33
method is missing a Javadoc comment. 39
'{' should be on the previous line. 40
'{' should be on the previous line. 42
'}' should be on the same line. 47
Empty catch block. 49
'{' should be on the previous line. 49

com/gotjava/web/taglibs/calendar/NoEventTag.java

Error Line
type Javadoc comment is missing an @author tag. 19
method is missing a Javadoc comment. 23
line longer than 80 characters 26
'if' is not followed by whitespace. 30
'(' is followed by whitespace. 30
')' is preceeded by whitespace. 30
'{' is not preceeded with whitespace. 30
'}' should be on the same line. 32
'else' construct must use '{}'s. 33
method is missing a Javadoc comment. 39
'{' should be on the previous line. 40
'{' should be on the previous line. 42
'}' should be on the same line. 47
Empty catch block. 49
'{' should be on the previous line. 49

com/gotjava/web/taglibs/calendar/EventTag.java

Error Line
Unused import - javax.servlet.jsp.JspWriter 8
Unused import - java.io.IOException 9
variable 'm_event' missing Javadoc. 18
variable 'm_event' must match pattern '^[a-z][a-zA-Z0-9]*$'. 18
variable 'm_id' missing Javadoc. 19
variable 'm_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. 19
method is missing a Javadoc comment. 22
'{' should be on the previous line. 23
'{' should be on the previous line. 28
line longer than 80 characters 29
',' needs to be followed by whitespace. 30
'}' should be on the same line. 32
'{' should be on the previous line. 34
method is missing a Javadoc comment. 42
'{' is not preceeded with whitespace. 42
method is missing a Javadoc comment. 46
'{' is not preceeded with whitespace. 46
method is missing a Javadoc comment. 50
'{' is not preceeded with whitespace. 50
method is missing a Javadoc comment. 54
'{' is not preceeded with whitespace. 54